0002091: allow unbundling of adodb

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0002091

[Cacti] Database

minor

always

2011-11-01 11:09

2011-11-07 20:24

Reporter

ktdreyer

View Status

public

Assigned To

rony

Priority

normal

Resolution

won't fix

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

Product Version

0.8.7h

Target Version

Product Build

Summary

0002091: allow unbundling of adodb

Description

Thanks for your work on Cacti.

A user at Fedora found that Cacti is bundling a very old version of adodb. The bug report is here: https://bugzilla.redhat.com/665773 [^]

Since php-adodb is already in Fedora and EPEL, I plan to remove Cacti's bundled adodb and use the system version instead. The patch that I'm using is attached. In order for this patch to go into upstream 0.8.7, I imagine you'd also want to set_include_path() to incorporate $config["library_path"]. For example:

set_include_path(get_include_path() . PATH_SEPARATOR . $config["library_path"]);

In this way Cacti will first load the system adodb if it exists, and otherwise use the bundled version.

Steps To Reproduce

Additional Information

Fedora's rationale for no bundled libraries is at
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries [^]

Tags

No tags attached.

Attached Files

cacti-0.8.7h-adodb.patch [^] (597 bytes) 2011-11-01 11:09 [Show Content] [Hide Content]

diff --git a/cacti/branches/0.8.7/include/global.php b/cacti/branches/0.8.7/include/global.php
index 4007469..2ebfc7e 100644
--- a/cacti/branches/0.8.7/include/global.php
+++ b/cacti/branches/0.8.7/include/global.php
@@ -192,7 +192,7 @@ if ((bool)ini_get("register_globals")) {
 }
 
 /* include base modules */
-include_once($config["library_path"] . "/adodb/adodb.inc.php");
+include_once("adodb/adodb.inc.php");
 include_once($config["library_path"] . "/database.php");
 include_once($config["library_path"] . "/functions.php");
 include_once($config["include_path"] . "/global_constants.php");

Relationships

Notes
(0005926) rony (administrator) 2011-11-07 20:24	ADODB will be removed from Cacti in version 1.0.0 coming early next year. I must note that I hope full testing of the updated ADODB has been performed and it works correctly with Cacti.

Issue History
Date Modified	Username	Field	Change
2011-11-01 11:09	ktdreyer	New Issue
2011-11-01 11:09	ktdreyer	File Added: cacti-0.8.7h-adodb.patch
2011-11-07 20:23	rony	Status	new => assigned
2011-11-07 20:23	rony	Assigned To	=> rony
2011-11-07 20:24	rony	Note Added: 0005926
2011-11-07 20:24	rony	Status	assigned => closed
2011-11-07 20:24	rony	Resolution	open => won't fix

Mantis 1.1.6[^]