Mantis - ISSUES

0002163: push_out_host() may be dreadfully slow

When thre is a lot of $template_fields per-field DB query may be very slow: I have seen more than 100 seconds runtime.

Patch attached removes this problem doing REPLACE INTO query in batches.

0002121: Graphs in tree mode with no permission display nothing

In tree mode, single or dual, if a graph is select for which the user has no permissions then nothing is displayed. The 'Access denied' message should be displayed. If nothing is displayed then is possible that the user will simply think something has gone wrong.

Attached is a simple patch which displays the 'ACCESS DENIED' message if a tree leaf is selected to which the user has no permission. (All the code is actually present, it is simply an argument to the 'html_graph_thumbnail_area' and 'html_graph_area' functions that needs to be set.)

Tested the patch, and it seems to work.

0002162: Error when authenticating a user whom the password contains UTF8 chars

I'm facing a strange issue with cacti 0.8.7g under Linux.

I was used to authenticate users against LDAP and all was working well.

It continues to work except for users that have passwords containing UTF8 chars. For example : é, è, ç...

It throws the following error in cacti.log :

02/01/2012 09:52:06 AM - AUTH LDAP_SEARCH: User found, DN '%s'CN=NOGUE test,OU=users,DC=Company
02/01/2012 09:52:06 AM - AUTH LDAP: Setting protocol version to 3
02/01/2012 09:52:06 AM - AUTH LDAP: General bind error, LDAP result: Decoding error
02/01/2012 09:52:06 AM - AUTH LOGIN: LDAP Error: General bind error, LDAP result: Decoding error

0002160: settings plugin mailer class puts email attachmets under multipart/related

Upgraded settings plugin from v0.6 to v7.1

Now when reportit plugin sends a report attached to an email the attachment is no longer visible in Thunderbird v9.0. "View source" shows it is there but it is invisible to the user.

The problem is that mailer class is composing a multipart/related type of message and puts any attachments (inline or otherwise) under this context. The code in mailer class is written in such a way that multipart/mixed can never be used.

RFC2387 specifies that multipart/related context "is intended for compound objects consisting of several inter-related body parts." In essence this means any images to embed in HTML body for example. All actual attachments (XLS files in my example) must be contained under multipart/mixed context.

RFC2387 also has this to say about Content-Disposition Headers:

"""
Using Content-Disposition headers in addition to Multipart/Related
provides presentation information to User Agents that do not
recognize Multipart/Related. They will treat the multipart as
Multipart/Mixed and they may find the Content-Disposition information
useful.

With Multipart/Related however, the application processing the
compound object determines the presentation style for all the
contained parts. In that context the Content-Disposition header
information is redundant or even misleading. Hence, User Agents that
understand Multipart/Related shall ignore the disposition type within
a Multipart/Related body part.
"""

So relying only on Content-Disposition headers for attachments is also not good enough.

It would seem that Thunderbird is handling the message correctly as per RFC. So settings plugin must be fixed.

It is also valid to have nested context. For example the structure of a plain-text/html message with embedded image and an attachment would look like this:

multipart/mixed
..multipart/alternative
....text/plain
....multipart/related
......text/html (refers to src=cid:Logo_cid)
......image/gif (Content-ID: )
..application/pdf (Content-Disposition: attachment)

0001225: HowTo use the index at an arbitrary place in the OID field

When scanning multidimensional snmptables (i.e. tables with several columns) oid_index_parse cannot be used to extract only the rows of interest as oid_index_parse only tries to match the regex. If no match occurs the record from the snmpwalk using oid_index is just altered instead of eliminiated.

See also

http://forums.cacti.net/about26851.html [^]

for more information.

I have written a small change to lib/data_query.php using a new field oid_index_filter to show what mean.

Also when using multidimensional snmptables the index extracted via the regex cannot be used as index into other tables which do not have the same number of columns. E.g. you cannot use this index to get the interface name/description. In my example I have used a new field "oid_subindex" which can be added to any query->fields with input and get

Third I would like to have a possibility to add part of the extracted OID from oid_index_filter being used as "text" using a field with index. The text could be a combination of the result of "oid_subindex" and either the field query->fields->"name"->name or a new field e.g.

Wire-Pair
OID/REGEXP:.*\.([1-4])$
....

Which then when using |query_wirePair| translates to "Wire-Pair 2" in the Graph Title.

I did a sample (for the moment without wish 3) which required only a change in the function "data_query_query_script_host" of the script "lib/data_query.php" which is attached (sorry the code is not cleaned up.

Please also refer to the thread where this requirement has been extensively been discussed and which also contains the XML I currently use to produce the desired result

http://forums.cacti.net/about26851.html [^]

I have tested this using hdsl2Shlds Tables described in RFC4319.

0002161: Graph management "graph()" function conflicts with graphviz PECL extension’s graph()

When running Cacti on a web server that also has the GraphViz PECL extension enabled, the Graph Management page will not load because it uses the function/method name "graph()", which is also used by the GraphViz extension. Unfortunately, I need the GraphViz extension loaded on this server because the same web server also runs NagVis and other monitoring websites.

0002159: cacti.sql not fully compliant with strict SQL mode

0002153: Cant search for patterns containing a forward-slash

Hey all,

Seems that the use of / as the delimiter in the preg_replace function causes a bug when searching using patterns that also contain a forward-slash. When I search for things like: Gi9/1 (cisco router interace) the search seems to work (the number of results are correct), but the "highlighting" function which changes the background color of the searched-for part of the trunkgroup name yellow causes the graph name to not display at all (broken HTML) . See my screenshot. Ross Kusler

0002157: Aggregate breaks graph filtering in Graph Managemnet

Aggregate plugin uses hook graphs_sql_where and modifies graphs SQL query to filter out graphs without an assigned host and template.

I assume this was made to prevent a user editing aggregate graphs by hand.

Unfortunately this means it is also harder or impossible to run any graph actions for these graphs.

Also a user may very well have some hand crafted graphs without an assigned host or template. These graphs would be invisible to the user.

I propose the use of this hook be removed from aggregate plugin.

0002158: Minor changes to grammar of displayed messages

In the 'Console->Settings->Visual' the two 'Log management' lines displayed are not well worded (poor grammar). Attached is a patch to correct this.

0002149: Cummultive patch from BorisL

The following patch accumulates all my local modifications to 087i. Not of all of them are mine (Host selector for example). Most of modifications are made for sake of Cacti stable & quick running on a very big environment.
Notable features (not in order):
- reindex_index, reindex_value support (0001225)
- SNMP class support (welcome in php 5.4.0), class replacement for previous versions
- autologin guest user (0001462)
- polling time column support, max_data_rate support (0002070)
- advanced graph filter (0002070)
- a number of speedups in poller (poller.php, lib/poller.php)

0002155: More options to adjust the look of aggregate graps

As discussed on the forums [http://forums.cacti.net/viewtopic.php?f=14&t=45853], [^] see there for en example of new features.

This patch builds on the current trunk of aggregate plugin to add more features to change the look-n-feel of aggregate graphs, without the need to change templates of graphs you want to aggregate.

Change summary:
* You can change graph configuration values (size, auto scale...) in aggregate template.
* You can override item type and CDEF for each graph item from original graph template.
* When using "Print all Legend Items" an extra empty line is inserted before Total lines.
* A bunch of bugfixes.
* A lot of code cleanup (moving duplicate code to functions, removing unused code).

I have done quite a bit of testing and am fairly confident I have not broken any existing functionality. Though it is still possible to generate broken graphs (or graphs that do not make sense) with the "right" combination of settings.

0002142: Graph Item sequence numbers in aggregate graph are wrong.

When saving aggregate graph items to DB the sequence numbers are assigned form 1 as they were POSTed from the editor from. Some items have only checkboxes in the form (GPRINTs ...) and are not POSTed if not checked. This can result in aggregate item parameters (color template, skip...) being applied to wrong graph items in aggregate graph.

This applies to aggregate graph and aggregate templates.

Attached patch:
* When saving aggregate graph (template) items we lookup source graph (template) item sequence and store with to aggregate item.

0002118: "Total Type" property of Aggregate Graph is not saved

In aggregate_graphs.php/form_save() the $_POST field "total_type" never gets called into $save array and is not saved to plugin_aggregate_graphs table.

0002117: Graph reordering does not work

Two issues with this:
* in aggregate_reorder_ds_graph the SQL to get data_template_rrd unsed in graph was wrong when $base was 0 (see additional info for details)

* in aggregate_create_update in array $attribs key "order_type" was used instead of "reorder"

0002116: Colors from Color Template are not applied in correct order

Currently colors are applied to graph items in order of id in plugin_aggregate_color_template_items instead of sequence. There is a "SORT BY sequence" missing in function aggregate_graphs_insert_graph_items. Patch attached.

0002154: When adding a new template cacti stops graphing

When adding new graphs or templates randomly cacti stops graphing.
Some of the graphs resume after refresh but not all.

0002152: Issue with filter on graphs_new.php

When you need to filter out lines from the data_query containing '/', the query result is empty rows with checkbox.
This issue affects filtering, in 'Graph Management' and 'Create Graphs for this Host'

0002151: When building HTML forms with sub_checkbox on_change parameter is not used

When building forms a field label can have a sub-checkbox. An example of this is "Use Per-Graph Value (Ignore this Value)" checkbox in templates.

Looking at the code in html_form.php this sub-checkbox should be able to have a on_change parameter with JS code that will be rendered to onChange parameter of the checkbox. But this is currently not possible, because the order of arguments to form_checkbox() is wrong.

Also the comments for form_checkbox function need updating.

Patch attached.

0002126: Syslog 1.22 - e-mail notification issues

In 1.22-2 threshold based alerts are not sending e-mail notifications when re-alert cycle is set, even though they appear in the "Alert Log" tab. With re-alert cycle disabled, e-mail are getting sent.

The issue appeared in version 1.22. In 1.21 this feature was functional.

0002150: usort_data_query_index() is broken

An error was introduced making replacement s/split/explode/ in usort_data_query_index().
Slash should not be escaped for use in explode.

0001462: Autologin guest user

Here is patch that disables build-in authorisation for guest user - it is very usefull in installation when everybody can view graphs.

0001337: Form to filter for graphs in host view mode

This patch adds a form that allows to filter graphs that are associated with host when it 'host' view mode.
The patch seems to be usefull when there are a lot of graphs for some host.

0002148: Multiple trees are not cycled correctly

When using multiple trees 'cycle' does not remember which tree was being looked at if the user moves off the page (e.g. to 'Console' or 'Graphs'), and then returns to 'cycle'. It always returns to the first tree (id = 1), which is typically the 'Default tree' (but not necessarily so).

Additionally, the default tree to be shown set in the cycle 'settings' is not remembered. If the user has no permissions to that default tree, then he/she simply gets the 'No graphs matching criteria' message, until the plugin has gone through one timed cycle (by default , after 1 minute).

The problem is that the relevant tree/leaf is not set in the javascript (in cycle.php), but is reset to the null string in cycle.js. As such whenever the user clicks on 'cycle', the tree settings are lost and replaced by the null string. The code then looks for the first tree to get started.

The solution is relatively simple: set the 'tree' and 'leaf' variables when the user clicks on 'cycle', and then never reset them. The values will be sent back and forth until the user changes them. We initialise them using the values set in settings. The rest of the code is already in place to handle when the user changes the tree and/or leaf.

Two small patches are attached. These have been tested, and work well.

0002147: Change default tree cycle from 'Top level' to 'All levels'

Using multiple trees, by default cycle will try and use the 'Top level'. In our case the top level is a header, as is the first branch, only under that are there graphs. As such 'top level' gives a 'No graphs matching criteria' message, whereas 'All levels' shows the graphs.

I'm simply providing this as a suggestion that the default is changed to 'All levels' since that should show graphs in all cases (?), whereas 'Top level' may or may not (and 'may not' occurs in our case).

Attached is a trivial patch for this.